Add support to ShmSize in Pods with Quadlet #24899
Open
+17
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Odilhao
force-pushed
the
pod-shm-size-issue
branch
4 times, most recently
from
a083f93 to
9c9f20a
Compare
|
/approve |
openshift-ci
bot
added
the
approved
ygalblum
requested changes
Dec 24, 2024
Odilhao
force-pushed
the
pod-shm-size-issue
branch
from
9808bee to
bf3acc1
Compare
ygalblum
reviewed
Dec 25, 2024
Odilhao
force-pushed
the
pod-shm-size-issue
branch
2 times, most recently
from
2cd9f72 to
d33ed1f
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Odilhao, rhatdan, ygalblum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I've restarted the failed test (doesn't seem related to this change) |
Want me to squash the commits? |
This closes containers#22915 Signed-off-by: Odilon Sousa <[email protected]>
Odilhao
force-pushed
the
pod-shm-size-issue
branch
from
d33ed1f to
d1a3f96
Compare
|
Did one last commit, squashing the 3 commits. |
Thanks, I missed the fact that there were multiple ones. I see there was an internal error in the build system. I'll try to re-run it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #22915
Add support for ShmSize in Pods created with Quadlet.
Add e2e tests.
Add new Docs entry.
Does this PR introduce a user-facing change?