Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add radio buttons to select WSL or Hyper-V in windows setup.exe #23936

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

l0rd
Copy link
Member

@l0rd l0rd commented Sep 11, 2024

Fixes #22492

Before

podman-setup-original

After

The last screenshot is when a previous version of podman is found, and we don't want the user to select the provider):

podman-setup-new1

podman-setup-new2

podman-setup-new3

Does this PR introduce a user-facing change?

The Windows installer has a new radio button to select the virtualization provider (WSLv2 or Hyper-V)

@rhatdan
Copy link
Member

rhatdan commented Sep 12, 2024

/approve
LGTM

Copy link
Contributor

openshift-ci bot commented Sep 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: l0rd, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2024
@baude
Copy link
Member

baude commented Sep 13, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 07397de into containers:main Sep 13, 2024
41 checks passed
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Dec 13, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Windows installer to use WiX 4 Thmutil RadioButton to allow WSL/Hyper-V selection
3 participants