Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

machine: Add -all-providers flag to machine list #23726

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

ashley-cui
Copy link
Member

@ashley-cui ashley-cui commented Aug 22, 2024

Podman machine list now supports a new option, --all-providers, which lists all machines from all providers.

Does this PR introduce a user-facing change?

Podman machine list now supports a new option, --all-providers, which lists all machines from all providers.

@openshift-ci openshift-ci bot added do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 22, 2024
@openshift-ci openshift-ci bot added release-note and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Aug 22, 2024
@ashley-cui
Copy link
Member Author

Unclear that the test will go through on Windows, since we WSL and HyperV don't share images, but I'm not on Windows today, so I'm throwing it at CI and hoping. Mac passed locally though.

@ashley-cui ashley-cui force-pushed the machlist branch 2 times, most recently from c7c418b to 49a1274 Compare August 22, 2024 20:39
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't there be at least a field in the list output that shows the user which provider the VM uses?

cmd/podman/machine/list.go Show resolved Hide resolved
pkg/machine/e2e/list_test.go Outdated Show resolved Hide resolved
pkg/machine/e2e/list_test.go Outdated Show resolved Hide resolved
cmd/podman/machine/list.go Show resolved Hide resolved
cmd/podman/machine/list.go Outdated Show resolved Hide resolved
@ashley-cui
Copy link
Member Author

@Luap99 List already has a field for provider :)

@Luap99
Copy link
Member

Luap99 commented Aug 26, 2024

@Luap99 List already has a field for provider :)

oops yes, I somehow looked for a provider field but it is called VM TYPE

@ashley-cui ashley-cui force-pushed the machlist branch 2 times, most recently from 7b96ca4 to 2b0e5dc Compare August 28, 2024 01:04
@ashley-cui
Copy link
Member Author

@containers/podman-maintainers @jakecorrenti @Luap99 @baude PTAL, TY!

cmd/podman/machine/list.go Show resolved Hide resolved
pkg/machine/provider/platform.go Outdated Show resolved Hide resolved
Podman machine list now supports a new option, --all-providers, which lists all machines from all providers.

Signed-off-by: Ashley Cui <[email protected]>
@ashley-cui
Copy link
Member Author

@containers/podman-maintainers PTAL

@mheon
Copy link
Member

mheon commented Aug 30, 2024

Code LGTM

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2024
Copy link
Contributor

openshift-ci bot commented Aug 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashley-cui, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ef905ef into containers:main Aug 30, 2024
92 checks passed
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Nov 29, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. machine release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants