-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
machine: Add -all-providers flag to machine list #23726
Conversation
Unclear that the test will go through on Windows, since we WSL and HyperV don't share images, but I'm not on Windows today, so I'm throwing it at CI and hoping. Mac passed locally though. |
c7c418b
to
49a1274
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't there be at least a field in the list output that shows the user which provider the VM uses?
@Luap99 List already has a field for provider :) |
oops yes, I somehow looked for a provider field but it is called VM TYPE |
7b96ca4
to
2b0e5dc
Compare
@containers/podman-maintainers @jakecorrenti @Luap99 @baude PTAL, TY! |
Podman machine list now supports a new option, --all-providers, which lists all machines from all providers. Signed-off-by: Ashley Cui <[email protected]>
@containers/podman-maintainers PTAL |
Code LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashley-cui, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Podman machine list now supports a new option, --all-providers, which lists all machines from all providers.
Does this PR introduce a user-facing change?