Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/machine/compression: skip decompress bar for empty file #23323

Merged
merged 1 commit into from
Jul 18, 2024
Merged

pkg/machine/compression: skip decompress bar for empty file #23323

merged 1 commit into from
Jul 18, 2024

Commits on Jul 18, 2024

  1. pkg/machine/compression: skip decompress bar for empty file 

    When the file is empty it is possible our code panics as bar.ProxyReader
returns nil when the bar is finished which is the case for 0 size as it
doesn't have to read anything from there. However as this happens on
different goroutines it is race and most of the time still works.

To fix this simply skip the progress bar setup for empty files.

While at it fix the deprecated argument in the tests.

Fixes containers#23281

Signed-off-by: Paul Holzinger <[email protected]>
    @Luap99
    Luap99 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    f630eeb View commit details
    Browse the repository at this point in the history