Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: Run tests with Zstd:chunked compression default #21903

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Mar 1, 2024

Inspired by #20633 ; now that #21571 is succeeding, let’s see what happens in the more complex case.

Does this PR introduce a user-facing change?

do not merge this

@openshift-ci openshift-ci bot added release-note do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 1, 2024
Copy link
Contributor

openshift-ci bot commented Mar 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtrmac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2024
@rhatdan
Copy link
Member

rhatdan commented Mar 1, 2024

WhooHoo Passed tests.

Copy link

github-actions bot commented Apr 1, 2024

A friendly reminder that this PR had no activity for 30 days.

@mtrmac mtrmac force-pushed the try-zstd_chunked-default branch from 0e174ef to 7b39108 Compare April 3, 2024 16:21
@github-actions github-actions bot removed the stale-pr label Apr 4, 2024
@mtrmac mtrmac force-pushed the try-zstd_chunked-default branch from 7b39108 to 84b528f Compare July 17, 2024 17:41
@mtrmac mtrmac force-pushed the try-zstd_chunked-default branch from 84b528f to 2e43b0a Compare October 14, 2024 20:20
@mtrmac
Copy link
Collaborator Author

mtrmac commented Nov 4, 2024

@mtrmac mtrmac force-pushed the try-zstd_chunked-default branch 3 times, most recently from 6488a88 to 39a5f78 Compare November 28, 2024 20:56
@mtrmac mtrmac force-pushed the try-zstd_chunked-default branch 3 times, most recently from 683d90a to 29b9c44 Compare December 14, 2024 00:21
@mtrmac mtrmac force-pushed the try-zstd_chunked-default branch 3 times, most recently from bcd6040 to a41ef14 Compare January 7, 2025 18:40
@mtrmac mtrmac force-pushed the try-zstd_chunked-default branch 3 times, most recently from dafd485 to 48ed8d1 Compare January 14, 2025 21:13
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@mtrmac mtrmac force-pushed the try-zstd_chunked-default branch 2 times, most recently from 94b7437 to 0a33fda Compare January 14, 2025 21:57
The Go image is too old, at least in the CI images

Signed-off-by: Miloslav Trmač <[email protected]>
The root of filepath.* now must exist.

Signed-off-by: Miloslav Trmač <[email protected]>
> go mod edit -replace github.com/opencontainers/runc=github.com/cyphar/[email protected]
per opencontainers/runc#4590 .

Signed-off-by: Miloslav Trmač <[email protected]>
Signed-off-by: Miloslav Trmač <[email protected]>
@mtrmac mtrmac force-pushed the try-zstd_chunked-default branch from 0a33fda to 0926906 Compare January 16, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants