podman pod stats: fix pod rm race

If a pod is removed when calling podman pod stats there is a race where the command might fail with no such pod. This is not a user error, like the ps/ls command skip it and move to the next one. Fixes #23327 Signed-off-by: Paul Holzinger <[email protected]>
containers · Jul 18, 2024 · b48e602 · b48e602
1 parent fcecc97
commit b48e602
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/pkg/domain/infra/abi/pods_stats.go b/pkg/domain/infra/abi/pods_stats.go
@@ -8,6 +8,7 @@ import (
 
  "github.com/containers/common/pkg/cgroups"
  "github.com/containers/podman/v5/libpod"
+ "github.com/containers/podman/v5/libpod/define"
  "github.com/containers/podman/v5/pkg/domain/entities"
  "github.com/containers/podman/v5/pkg/rootless"
  "github.com/docker/go-units"
@@ -39,6 +40,10 @@ func (ic *ContainerEngine) podsToStatsReport(pods []*libpod.Pod) ([]*entities.Po
  for i := range pods { // Access by index to prevent potential loop-variable leaks.
  podStats, err := pods[i].GetPodStats(nil)
  if err != nil {
+ // pod was removed, skip it
+ if errors.Is(err, define.ErrNoSuchPod) {
+ continue
+ }
  return nil, err
  }
  podID := pods[i].ID()[:12]