-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide support for cache_from and cache_to fields #1092
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. It looks good in principle.
What's missing:
- unit tests. I did some refactoring and added unit tests for image building functionality in Add unit tests for image building #1094
- release note. Please see newsfragments/README.txt file
Also, podman build documentation says that cache-from is ignored unless --layers
is specified. I suppose this PR won't do what user expects as is, what am I missing?
Also, please rebase instead of merging main, thanks! |
@p12tic about the branch update (merging vs rebasing): Can't the "update with merge" be disabled on the GH UI? I just clicked on "update" and it did a merge. Now I have seen I had the option to "update with rebase", but if that is not valid... maybe should just not appear at all? |
Unfortunately github UI does not support this. They have different options for actual merging, but for the update button - no. |
Still needs a release note.
|
Gosh, too many holidays. Done! |
Signed-off-by: Felix Rubio <[email protected]>
@p12tic I have seen there were changes to main, and I have rebased my branch on top of it. Do you need to approve again? |
I also combined the fixup commits into the feature commit, so that a commit groups one logical change. See https://metal-k8s.readthedocs.io/en/2.4.1/developer/best_practices/commit.html for an example of commit best practices. Podman-compose should probably have a link to similar page in PR template. |
Currently the fields cache_from and cache_to on the build are ignored. This PR provides support for them in the build block, just by propagating them to the call to podman.