-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RPM/Packit: Fix wasm conditionals, cleanup rpm spec, update packit config #1533
Conversation
Ephemeral COPR build failed. @containers/packit-build please check. |
podman system tests failed. @containers/packit-build please check. |
LGTM |
Ephemeral COPR build failed. @containers/packit-build please check. |
podman system tests failed. @containers/packit-build please check. |
Ephemeral COPR build failed. @containers/packit-build please check. |
podman system tests failed. @containers/packit-build please check. |
Ephemeral COPR build failed. @containers/packit-build please check. |
podman system tests failed. @containers/packit-build please check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
should we merge this or wait all the CI tests are green?
let's wait until test jobs are green. |
464e4b8
to
03a827f
Compare
/packit test packit/containers-common#2145 |
/packit test containers/common#2145 |
1 similar comment
/packit test containers/common#2145 |
/packit test containers/common#2145 |
/packit test containers/common#2145 |
Signed-off-by: Giuseppe Scrivano <[email protected]>
bf486e2
to
b8258f8
Compare
/packit test containers/common#2145 |
c775b3e
to
4e8755c
Compare
/packit test containers/common#2145 |
4e8755c
to
5b4ad8e
Compare
/packit test containers/common#2145 |
5b4ad8e
to
f97dab0
Compare
…nfig 1. Wrongly mentioned conditionals were causing crun-wasm package creation on CentOS Stream 10 and ELN environments which don't have wasm support yet. 2. All environments that end up consuming rpm/crun.spec have rpmautospec enabled so we don't need these conditionals anymore. CentOS Stream 9 should soon get rpmautospec support as well, and the current lack of it is not really a blocker to removal of these conditionals. 3. Simplify TMT tests Signed-off-by: Lokesh Mandvekar <[email protected]>
f97dab0
to
7fcede6
Compare
@giuseppe PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
green CI yey!
LGTM
Wrongly mentioned conditionals were causing crun-wasm package
creation on CentOS Stream 10 and ELN environments which don't have
wasm support yet.
All environments that end up consuming rpm/crun.spec have rpmautospec
enabled so we don't need these conditionals anymore. CentOS Stream 9
should soon get rpmautospec support as well, and the current lack of it
is not really a blocker to removal of these conditionals.
Simplify TMT tests