Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop --tty on exec #484

Merged
merged 1 commit into from
Jan 9, 2024
Merged

drop --tty on exec #484

merged 1 commit into from
Jan 9, 2024

Conversation

haircommander
Copy link
Collaborator

as gvisor doesn't use it, and runc/crun don't need it, as they'll only use it if the process args aren't defined, which conmon always does

fixes #483

as gvisor doesn't use it, and runc/crun don't need it, as they'll only use it if
the process args aren't defined, which conmon always does

Signed-off-by: Peter Hunt <[email protected]>
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member

rhatdan commented Jan 9, 2024

LGTM

@rhatdan rhatdan merged commit 4fcd0c4 into containers:main Jan 9, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants