logging: Respect log-size-max immediately after open #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinetd
force-pushed
the
logs_maxsize
branch
from
7c989bc to
4444e76
Compare
|
The test that failed ( I'll assume that's unrelated and ignore it unless told otherwise. |
|
couple of nits, feel free to ignore the test failures :) |
martinetd
force-pushed
the
logs_maxsize
branch
from
4444e76 to
a03d1a7
Compare
|
LGTM, @giuseppe PTAL |
|
could you please rebase so the CI will (hopefully) pass? |
When a container keeps restarting, conmon restarts and opens the log file with O_APPEND every single time, resetting bytes_written to 0 with a non-empty file. If the container fails before writting log-size-max bytes then the log keeps growing indefinitely, potentially using up all the available space. This should be kept in check: initialize bytes_written to the file's current size, so that it can be reset if required (it's possible that the file gets re-open before the first write if it was already above the limit, but that should almost never happen in practice) In order to make this simpler make bytes written global variables Signed-off-by: Dominique Martinet <[email protected]>
martinetd
force-pushed
the
logs_maxsize
branch
from
a03d1a7 to
116675e
Compare
|
/lgtm |
It looks like that did the trick. I don't suppose there are plans for a 2.1.10 a couple of days after the 2.1.9 is there? :) |
giuseppe
approved these changes
Dec 15, 2023
|
this is included in 2.1.10 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a container keeps restarting, conmon restarts and opens the log file with O_APPEND every single time, resetting bytes_written to 0 with a non-empty file.
If the container fails before writting log-size-max bytes then the log keeps growing indefinitely, potentially using up all the available space.
This should be kept in check: initialize bytes_written to the file's current size, so that it can be reset if required (it's possible that the file gets re-open before the first write if it was already above the limit, but that should almost never happen in practice)
In order to make this simpler make bytes written global variables
This bit us with podman recently with a bad container config and restart=on-failure; I thought it wasn't a problem before? but checking the code I don't see how this would be a new problem, so I probably failed to check this when adding the podman
--log-opt max-size=xxxparameter...Thanks!