-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apparmor: fix parsing beta/alpha version #1689
Conversation
Copied from github.com/moby/moby who already has a fix for it. Tested manually on a Ubuntu 23.10 (beta) VM. Fixes: #containers/podman/issues/20278 Signed-off-by: Valentin Rothberg <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, Luap99, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
git clean -xdf go mod download go mod vendor tar zcvf ../cri-o_1.28.2.orig.tar.gz --exclude=.git . debuild -uc -us cp cri-o.spec ../cri-o_1.28.2-1.spec cp ../cri-o*1.28.2*.{gz,xz,spec,dsc} /osc/home\:alvistack/cri-o-cri-o-1.28.2/ rm -rf ../cri-o*1.28.2*.* See containers/common#1689 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
git clean -xdf go mod download go mod vendor tar zcvf ../cri-o_1.27.1.orig.tar.gz --exclude=.git . debuild -uc -us cp cri-o.spec ../cri-o_1.27.1-1.spec cp ../cri-o*1.27.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/cri-o-cri-o-1.27.1/ rm -rf ../cri-o*1.27.1*.* See containers/common#1689 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
git clean -xdf go mod download go mod vendor tar zcvf ../cri-o_1.26.4.orig.tar.gz --exclude=.git . debuild -uc -us cp cri-o.spec ../cri-o_1.26.4-1.spec cp ../cri-o*1.26.4*.{gz,xz,spec,dsc} /osc/home\:alvistack/cri-o-cri-o-1.26.4/ rm -rf ../cri-o*1.26.4*.* See containers/common#1689 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
git clean -xdf go mod download go mod vendor tar zcvf ../cri-o_1.28.2.orig.tar.gz --exclude=.git . debuild -uc -us cp cri-o.spec ../cri-o_1.28.2-1.spec cp ../cri-o*1.28.2*.{gz,xz,spec,dsc} /osc/home\:alvistack/cri-o-cri-o-1.28.2/ rm -rf ../cri-o*1.28.2*.* See containers/common#1689 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
git clean -xdf go mod download go mod vendor curl -skL https://github.com/containers/common/commit/f2d1b1442077c26c800106219e9e9b2f3838e08b.patch | patch -p1 -d vendor/github.com/containers/common/ tar zcvf ../cri-o_1.26.4.orig.tar.gz --exclude=.git . debuild -uc -us cp cri-o.spec ../cri-o_1.26.4-1.spec cp ../cri-o*1.26.4*.{gz,xz,spec,dsc} /osc/home\:alvistack/cri-o-cri-o-1.26.4/ rm -rf ../cri-o*1.26.4*.* See containers/common#1689 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
git clean -xdf go mod download go mod vendor curl -skL https://github.com/containers/common/commit/f2d1b1442077c26c800106219e9e9b2f3838e08b.patch | patch -p1 -d vendor/github.com/containers/common/ tar zcvf ../cri-o_1.27.1.orig.tar.gz --exclude=.git . debuild -uc -us cp cri-o.spec ../cri-o_1.27.1-1.spec cp ../cri-o*1.27.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/cri-o-cri-o-1.27.1/ rm -rf ../cri-o*1.27.1*.* See containers/common#1689 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
git clean -xdf go mod download go mod vendor curl -skL https://github.com/containers/common/commit/f2d1b1442077c26c800106219e9e9b2f3838e08b.patch | patch -p1 -d vendor/github.com/containers/common/ tar zcvf ../cri-o_1.28.2.orig.tar.gz --exclude=.git . debuild -uc -us cp cri-o.spec ../cri-o_1.28.2-1.spec cp ../cri-o*1.28.2*.{gz,xz,spec,dsc} /osc/home\:alvistack/cri-o-cri-o-1.28.2/ rm -rf ../cri-o*1.28.2*.* See containers/common#1689 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
git clean -xdf go mod download go mod vendor curl -skL https://github.com/containers/common/commit/f2d1b1442077c26c800106219e9e9b2f3838e08b.patch | patch -p1 -d vendor/github.com/containers/common/ tar zcvf ../cri-o_1.26.4.orig.tar.gz --exclude=.git . debuild -uc -us cp cri-o.spec ../cri-o_1.26.4-1.spec cp ../cri-o*1.26.4*.{gz,xz,spec,dsc} /osc/home\:alvistack/cri-o-cri-o-1.26.4/ rm -rf ../cri-o*1.26.4*.* See containers/common#1689 See cri-o#7490 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
git clean -xdf go mod download go mod vendor curl -skL https://github.com/containers/common/commit/f2d1b1442077c26c800106219e9e9b2f3838e08b.patch | patch -p1 -d vendor/github.com/containers/common/ tar zcvf ../cri-o_1.27.1.orig.tar.gz --exclude=.git . debuild -uc -us cp cri-o.spec ../cri-o_1.27.1-1.spec cp ../cri-o*1.27.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/cri-o-cri-o-1.27.1/ rm -rf ../cri-o*1.27.1*.* See containers/common#1689 See cri-o#7490 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
git clean -xdf go mod download go mod vendor curl -skL https://github.com/containers/common/commit/f2d1b1442077c26c800106219e9e9b2f3838e08b.patch | patch -p1 -d vendor/github.com/containers/common/ tar zcvf ../cri-o_1.28.2.orig.tar.gz --exclude=.git . debuild -uc -us cp cri-o.spec ../cri-o_1.28.2-1.spec cp ../cri-o*1.28.2*.{gz,xz,spec,dsc} /osc/home\:alvistack/cri-o-cri-o-1.28.2/ rm -rf ../cri-o*1.28.2*.* See containers/common#1689 See cri-o#7490 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
git clean -xdf go mod download go mod vendor curl -skL https://github.com/containers/common/commit/f2d1b1442077c26c800106219e9e9b2f3838e08b.patch | patch -p1 -d vendor/github.com/containers/common/ tar zcvf ../cri-o_1.28.2.orig.tar.gz --exclude=.git . debuild -uc -us cp cri-o.spec ../cri-o_1.28.2-1.spec cp ../cri-o*1.28.2*.{gz,xz,spec,dsc} /osc/home\:alvistack/cri-o-cri-o-1.28.2/ rm -rf ../cri-o*1.28.2*.* See containers/common#1689 See cri-o#7490 See cri-o#7491 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
git clean -xdf go mod download go mod vendor curl -skL https://github.com/containers/common/commit/f2d1b1442077c26c800106219e9e9b2f3838e08b.patch | patch -p1 -d vendor/github.com/containers/common/ tar zcvf ../cri-o_1.27.1.orig.tar.gz --exclude=.git . debuild -uc -us cp cri-o.spec ../cri-o_1.27.1-1.spec cp ../cri-o*1.27.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/cri-o-cri-o-1.27.1/ rm -rf ../cri-o*1.27.1*.* See containers/common#1689 See cri-o#7490 See cri-o#7491 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
git clean -xdf go mod download go mod vendor curl -skL https://github.com/containers/common/commit/f2d1b1442077c26c800106219e9e9b2f3838e08b.patch | patch -p1 -d vendor/github.com/containers/common/ tar zcvf ../cri-o_1.26.4.orig.tar.gz --exclude=.git . debuild -uc -us cp cri-o.spec ../cri-o_1.26.4-1.spec cp ../cri-o*1.26.4*.{gz,xz,spec,dsc} /osc/home\:alvistack/cri-o-cri-o-1.26.4/ rm -rf ../cri-o*1.26.4*.* See containers/common#1689 See cri-o#7490 See cri-o#7491 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
git clean -xdf go mod download go mod vendor tar zcvf ../cri-o_1.28.2.orig.tar.gz --exclude=.git . debuild -uc -us cp cri-o.spec ../cri-o_1.28.2-1.spec cp ../cri-o*1.28.2*.{gz,xz,spec,dsc} /osc/home\:alvistack/cri-o-cri-o-1.28.2/ rm -rf ../cri-o*1.28.2*.* See containers/common#1689 See cri-o#7490 See cri-o#7491 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
git clean -xdf go mod download go mod vendor tar zcvf ../cri-o_1.27.1.orig.tar.gz --exclude=.git . debuild -uc -us cp cri-o.spec ../cri-o_1.27.1-1.spec cp ../cri-o*1.27.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/cri-o-cri-o-1.27.1/ rm -rf ../cri-o*1.27.1*.* See containers/common#1689 See cri-o#7490 See cri-o#7491 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
git clean -xdf go mod download go mod vendor tar zcvf ../cri-o_1.26.4.orig.tar.gz --exclude=.git . debuild -uc -us cp cri-o.spec ../cri-o_1.26.4-1.spec cp ../cri-o*1.26.4*.{gz,xz,spec,dsc} /osc/home\:alvistack/cri-o-cri-o-1.26.4/ rm -rf ../cri-o*1.26.4*.* See containers/common#1689 See cri-o#7490 See cri-o#7491 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
git clean -xdf go mod download go mod vendor tar zcvf ../cri-o_1.27.1.orig.tar.gz --exclude=.git . debuild -uc -us cp cri-o.spec ../cri-o_1.27.1-1.spec cp ../cri-o*1.27.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/cri-o-cri-o-1.27.1/ rm -rf ../cri-o*1.27.1*.* See containers/common#1689 See cri-o#7490 See cri-o#7491 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
git clean -xdf go mod download go mod vendor tar zcvf ../cri-o_1.28.2.orig.tar.gz --exclude=.git . debuild -uc -us cp cri-o.spec ../cri-o_1.28.2-1.spec cp ../cri-o*1.28.2*.{gz,xz,spec,dsc} /osc/home\:alvistack/cri-o-cri-o-1.28.2/ rm -rf ../cri-o*1.28.2*.* See containers/common#1689 See cri-o#7490 See cri-o#7491 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
git clean -xdf go mod download go mod vendor tar zcvf ../cri-o_1.27.2.orig.tar.gz --exclude=.git . debuild -uc -us cp cri-o.spec ../cri-o_1.27.2-1.spec cp ../cri-o*1.27.2*.{gz,xz,spec,dsc} /osc/home\:alvistack/cri-o-cri-o-1.27.2/ rm -rf ../cri-o*1.27.2*.* See containers/common#1689 See cri-o#7490 See cri-o#7491 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
git clean -xdf go mod download go mod vendor tar zcvf ../cri-o_1.27.2.orig.tar.gz --exclude=.git . debuild -uc -us cp cri-o.spec ../cri-o_1.27.2-1.spec cp ../cri-o*1.27.2*.{gz,xz,spec,dsc} /osc/home\:alvistack/cri-o-cri-o-1.27.2/ rm -rf ../cri-o*1.27.2*.* See containers/common#1689 See cri-o#7490 See cri-o#7491 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
git clean -xdf go mod download go mod vendor tar zcvf ../cri-o_1.28.2.orig.tar.gz --exclude=.git . debuild -uc -us cp cri-o.spec ../cri-o_1.28.2-1.spec cp ../cri-o*1.28.2*.{gz,xz,spec,dsc} /osc/home\:alvistack/cri-o-cri-o-1.28.2/ rm -rf ../cri-o*1.28.2*.* See containers/common#1689 See cri-o#7490 See cri-o#7491 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
Copied from github.com/moby/moby who already has a fix for it. Tested manually on a Ubuntu 23.10 (beta) VM.
Fixes: #containers/podman/issues/20278