Don't fall back if imagesIDsForManifest fails

If we can't find the image we have just pulled by digest, the image was probably already removed, and returning candidate.Value could only possibly point at a _different_ image with the same tag. Instead, fail immediately. Signed-off-by: Miloslav Trmač <[email protected]>
containers · Oct 15, 2024 · 4cf7957 · 4cf7957
1 parent d020acd
commit 4cf7957
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/libimage/pull.go b/libimage/pull.go
@@ -699,10 +699,11 @@ func (r *Runtime) copySingleImageFromRegistry(ctx context.Context, imageName str
 		}
 
 		logrus.Debugf("Pulled candidate %s successfully", candidateString)
-		if ids, err := r.imagesIDsForManifest(manifestBytes, sys); err == nil {
-			return ids, nil
+		ids, err := r.imagesIDsForManifest(manifestBytes, sys)
+		if err != nil {
+			return nil, err
 		}
-		return []string{candidate.Value.String()}, nil
+		return ids, nil
 	}
 
 	if localImage != nil && pullPolicy == config.PullPolicyNewer {