Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async:when the client request failed. Learn from ttrpc-go #259

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

jokemanfire
Copy link
Contributor

The error type shuld more friendly to external interfaces

The error type shuld more friendly to external interfaces

Signed-off-by: jokemanfire <[email protected]>
@jokemanfire
Copy link
Contributor Author

This error type is not as my expect when I take this pr
containerd/rust-extensions#318

Copy link
Member

@Tim-Zhang Tim-Zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jokemanfire

@teawater teawater merged commit a0e0d66 into containerd:master Nov 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants