Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runc: split Pipe, Io, and PipedIo to async and sync modules #335

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Mossaka
Copy link
Member

@Mossaka Mossaka commented Nov 5, 2024

An attempt to resolve #326 (comment)

Questions: should we add cargo build -p runc to the CI since the CI is not building runc with default target at all?

Can you take a look at this PR? @ningmingxiao, @mxpv

@github-actions github-actions bot added the C-runc runc helper label Nov 5, 2024
@jokemanfire
Copy link
Contributor

jokemanfire commented Nov 6, 2024

I think this change is great ,but how about using pipe but not using fifo directly, because there's so many problem which I meet in FIFO direct. #278

@Mossaka
Copy link
Member Author

Mossaka commented Nov 6, 2024

My goal is to do a refactoring so that the code can compile. I am happy to rebase on your Pr if that works

@jokemanfire
Copy link
Contributor

My goal is to do a refactoring so that the code can compile. I am happy to rebase on your Pr if that works

I think I should wait for your split , because I forget the sync feature too, that pipe problem is only existing in async feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-runc runc helper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants