Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci:add cri-integration #329

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ningmingxiao
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the T-CI Changes in project's CI label Oct 24, 2024
@ningmingxiao ningmingxiao force-pushed the add_cri_ci branch 7 times, most recently from 50e889a to bf0686b Compare October 25, 2024 02:54
@jsturtevant
Copy link
Contributor

@ningmingxiao We already have an integration step in the workflow that does the setup and runs the tests. What is the purpose of adding this additional step?

@ningmingxiao
Copy link
Contributor Author

ningmingxiao commented Oct 31, 2024

because containerd have make integration and make cri-integration
https://github.com/containerd/containerd/blob/main/BUILDING.md
make integration is not enough. @jsturtevant
TestContainerStats TestContainerListStats TestContainerListStatsWithIdFilter TestContainerListStatsWithSandboxIdFilter TestContainerListStatsWithIdSandboxIdFilter will fail.

Signed-off-by: ningmingxiao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-CI Changes in project's CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants