-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: shim: Complete the metrics collection for cgroup v1 #275
base: main
Are you sure you want to change the base?
Conversation
Got you. Will review it... |
I think it's great to have a complete cgroupv1 stats collection, but given #258 suggests that the complex logic of cgroups stats should not reside in the shim crate, I would recommend that we should take a look at if libcgroups could be of use. In particular, I am fully aware that we are using cgroups-rs, so what I am proposing here is to evaluate whether or not CC @utam0k |
I'm happy to collaborate with you if possible! |
715056b
to
5a2d5c2
Compare
Hey @Mossaka, can you give a bit more context on |
Complete the metrics collection for cgroup v1 so that containerd can obtain complete metrics information