Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows statistics protobuf pacakge #178

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

jsturtevant
Copy link
Contributor

This adds the necessary protobuff files and configures it so we can generate ttrpc stats endpoint. The import for a package would look like:

use containerd_shim_protos::windows::stats::{Statistics, WindowsContainerStatistics}

@github-actions github-actions bot added T-docs Improvements or additions to documentation C-shim-protos Shim protos labels Aug 18, 2023
@jsturtevant
Copy link
Contributor Author

looks like the golang issue is now regular occurance

go: github.com/AdaLogics/[email protected] (replaced by github.com/AdamKorcz/[email protected]): version "v0.0.0-20230111232327-1f10f66a31bf" invalid: unknown revision 1f10f66a31bf

@mxpv
Copy link
Member

mxpv commented Aug 21, 2023

looks like the golang issue is now regular occurance

This should be fixed with #179, right? Should we rebase the PR?

@github-actions github-actions bot added the OS-windows A change is specific to Windows label Aug 21, 2023
@mxpv mxpv merged commit 11a1618 into containerd:main Aug 21, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-shim-protos Shim protos OS-windows A change is specific to Windows T-docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants