Handle cgroup v1 or v2 to enable resource updates #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsturtevant
force-pushed
the
fix-update-cgroup-taskupdate
branch
from
4bdfe9a
to
6abb8b4
Compare
dcantah
reviewed
Aug 11, 2023
jsturtevant
force-pushed
the
fix-update-cgroup-taskupdate
branch
from
6abb8b4
to
7fe4fa3
Compare
|
that failure wasn't related to the shim tests, it was a go get issue. |
jsturtevant
force-pushed
the
fix-update-cgroup-taskupdate
branch
from
7fe4fa3
to
c272eae
Compare
|
same go get error again (but other integration tests passed just fine :-/) |
jsturtevant
force-pushed
the
fix-update-cgroup-taskupdate
branch
from
c272eae
to
7bdc6a2
Compare
|
go get is stuggling today, I will try again Monday morning. |
dcantah
approved these changes
Aug 13, 2023
jsturtevant
force-pushed
the
fix-update-cgroup-taskupdate
branch
from
7bdc6a2
to
103c093
Compare
|
Same go get issue today. I will need to look deeper :-/ |
jsturtevant
force-pushed
the
fix-update-cgroup-taskupdate
branch
from
103c093
to
c89eb30
Compare
Signed-off-by: James Sturtevant <[email protected]>
jsturtevant
force-pushed
the
fix-update-cgroup-taskupdate
branch
from
c89eb30
to
3e7647d
Compare
mxpv
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #122
This test was failing in 22.04 because it has cgroups v2. This follows same pattern as the metrics to select either v1 or v2.