feat(runc-shim): add a version flag #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxpv
reviewed
Aug 9, 2023
mxpv
approved these changes
Aug 9, 2023
|
OK, I'll review it ASAP |
Burning1020
suggested changes
Aug 10, 2023
Burning1020
reviewed
Aug 15, 2023
Mossaka
force-pushed
the
version
branch
2 times, most recently
from
a96759e
to
ed0e9d1
Compare
|
you've hit #147 (comment) with the integration tests. |
Burning1020
approved these changes
Aug 21, 2023
|
@Mossaka a rebase should fix the integration test failing |
Signed-off-by: jiaxiao zhou <[email protected]>
|
Let me try rerunning the CI |
|
Once we get this PR merged, can we get a new release cut? |
|
@mxpv could we merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two things
parsefunction fromcontainerd-shimcrate and move the namespace check to the boostrap functionCloses #120