feat: resolve a name clash of the libcontainer features #246
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsturtevant
reviewed
Aug 17, 2023
Makefile
Outdated
| # compiling against libcontainer's default features (dependency on libseccomp) | ||
| cargo build -p containerd-shim-wasm --features libcontainer_default $(RELEASE_FLAG) | ||
| # compiling against libcontainer's cgroups v2 feature (no dependency on libseccomp) | ||
| cargo build -p containerd-shim-wasm --features cgroupsv2 $(RELEASE_FLAG) |
There was a problem hiding this comment.
do we need to build each Indvidual feature or can we use something like --all-features? I've seen that in other projects and I am not sure what the best thing to do here. Otherwise it seems like we need to do every combination that is exposed.
There was a problem hiding this comment.
--all-features are just additively adding all the features, and that's good to build. But we also want to make sure each individual feature is buildable.
Unrelated: I am thinking about writing an integration tests to grep the output of cargo update on different features to make sure libseccomp is adding/deleting.
|
Is the space failure due to extra build caches for each configuration taking up space? |
Mossaka
force-pushed
the
feature-name-clash
branch
from
e2fc485
to
390e1b4
Compare
Signed-off-by: jiaxiao zhou <[email protected]>
Mossaka
force-pushed
the
feature-name-clash
branch
from
390e1b4
to
3af1c06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit resolves a name clash of the
libcontainerfeature from the containerd-shim-wasm, which undesirably forces all other features to bring in libseccomp and systemd dependencies. By renaminglibcontainertolibcontainer_default, the consumer of the crate can specifycgroupsv2to directly access libcontainer's v2 feature without bringing in libseccomp and systemd dependencies.This will resolve this concerns @0xE282B0 raised deislabs/containerd-wasm-shims#122 (comment)
FYI @jsturtevant