[WIP] Add support for writing to ptys #3591
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: apostasie <[email protected]>
|
Failure is unrelated. |
AkihiroSuda
reviewed
Oct 24, 2024
| defer pty.Close() | ||
| defer tty.Close() | ||
|
|
||
| for _, writer := range gc.ptyWriters { |
There was a problem hiding this comment.
Shouldn't we use errgroup to wait for the routines?
There was a problem hiding this comment.
Yes indeed.
Will update.
There was a problem hiding this comment.
Reverting to draft for the time being - being abroad I may not have time to look into this immediately.
Thanks @AkihiroSuda .
apostasie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the next step in removing
unbufferfrom our testing, adding the ability to write to stdin with ptys.