Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ensurecontainerstarted logic and better debug #3573

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Fix ensurecontainerstarted logic and better debug #3573

merged 1 commit into from
Oct 18, 2024

Conversation

apostasie
Copy link
Contributor

Breakout of #3535

This fixes logic issues in hasty porting of EnsureContainerStarted, and enhances debugability.

@apostasie apostasie marked this pull request as draft October 18, 2024 20:18
@apostasie apostasie mentioned this pull request Oct 18, 2024
Open
@apostasie apostasie marked this pull request as ready for review October 18, 2024 20:47
@AkihiroSuda AkihiroSuda added the area/ci e.g., CI failure label Oct 18, 2024
@AkihiroSuda AkihiroSuda added this to the v2.0.0 milestone Oct 18, 2024
AkihiroSuda
AkihiroSuda approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit e97fe5a into containerd:main Oct 18, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
area/ci e.g., CI failure
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@apostasie @AkihiroSuda