Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focused solely on rewriting builder tests with the new test framework.
Any other changes (in testutil) are removal of no-longer used helpers, and making sure we can compile on other platforms as we make test files move away from _platform.go patterns.
Besides 1-1 rewrite, a few test changes are worth noting:
builder prune
op that was previously in place. The key upside is that tests can now be ran in parallel instead of sequentially, with no downside as far as I can tell (if there is any, we can always --no-cache where it matters)This PR has been reduced as much as feasible to not contain any other changes.
I know it is still big (1k lines)... - lmk if you think there is a good way to break this up.