Login & authentication rework, part 2: prompt cleanup #3392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apostasie
changed the title
apostasie
changed the title
apostasie
force-pushed
the
dev-login-2
branch
from
72a5775
to
3c9f561
Compare
|
Will rebase once |
Signed-off-by: apostasie <[email protected]>
apostasie
force-pushed
the
dev-login-2
branch
from
3c9f561
to
23aca88
Compare
|
Rebased. |
AkihiroSuda
approved these changes
Sep 4, 2024
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small PR that comes on top of #3293 and should be merged after it, in preparation for more login cleanup.
Its purpose is solely to isolate user input prompting cleanly, and provide proper error reporting for it.
This is purely refactoring and cleanup.