Test fixes #3207
Merged
Test fixes #3207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: apostasie <[email protected]>
|
Green. @AkihiroSuda and team, can you take a look at your convenience? Thanks a lot. |
|
Maybe this sort of PR should be split to 3 commits in the next time |
Will do. Thanks for the guidance. Appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Canary build #3189 (without any retry) has ran green for the first time today.
These here are the remaining fixes in the canary branch that have yet to be merged, and that should fix the last flaky tests.
In a shell:
builder pruneare not safe to be parallelized - disabling parallel on themDelayOnceReader- these things are inherently flaky, but the new extended delay seems to work betterOnce this is merged, I suggest we give it another week of running the Canary PR against main regularly to confirm we are constantly green, then we can consider merging it.