Refactored container wait and make it public #2384
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Li <[email protected]>
AkihiroSuda
reviewed
Jul 21, 2023
| allErr = multierror.Append(allErr, waitErr) | ||
| } | ||
| } | ||
| return allErr | ||
| } | ||
|
|
||
| func waitContainer(ctx context.Context, w io.Writer, container containerd.Container) error { | ||
| func WaitContainer(ctx context.Context, container containerd.Container) (code int64, err error) { |
There was a problem hiding this comment.
This should be pkg/containerutil.Wait()
https://github.com/containerd/nerdctl/blob/main/pkg/containerutil/containerutil.go
|
Needs rebase |
|
Hey @KevinLiAWS Do you think you could rebase this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait container is useful for external callers.
The current container wait private method only return the error without the container status code, instead, it print the code.
This PR refactored the code to return both the status code and error, and make it public.
From docker API, the status code is int64, so converted the original uint32 to int64, and also use -1 to indicate non container wait error status.