Skip to content

Commit

Permalink
fix: Allow to delete images when names of images are short digest ids…
Browse files Browse the repository at this point in the history
… of another images

Fixed not to run `canonicalRef.String()` when canonicalRef is nil.

    ```
    canonicalRef, err := referenceutil.ParseAny(req)
    ```

Also, fixed not to run TestIssue3016 on windows.

Signed-off-by: Hayato Kiwata <[email protected]>
  • Loading branch information
haytok committed Oct 17, 2024
1 parent 5b7ccd7 commit a008261
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions cmd/nerdctl/image/image_remove_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,9 @@ func TestIssue3016(t *testing.T) {
testCase.SubTests = []*test.Case{
{
Description: "Issue #3016 - Tags created using the short digest ids of container images cannot be deleted using the nerdctl rmi command.",
Require: test.Require(
test.Not(test.Windows),
),
Setup: func(data test.Data, helpers test.Helpers) {
helpers.Ensure("pull", alpineImageName)
helpers.Ensure("pull", busyboxImageName)
Expand Down

0 comments on commit a008261

Please sign in to comment.