fix: add login component username validation

Signed-off-by: Czékus Máté <[email protected]>
containerd · Jul 5, 2024 · 74e46ef · 74e46ef
1 parent 866a176
commit 74e46ef
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/cmd/nerdctl/login.go b/cmd/nerdctl/login.go
@@ -19,6 +19,7 @@ package main
 import (
  "errors"
  "io"
+ "net/url"
  "strings"
 
  "github.com/containerd/log"
@@ -82,6 +83,11 @@ func processLoginOptions(cmd *cobra.Command) (types.LoginCommandOptions, error)
  password = strings.TrimSuffix(string(contents), "\n")
  password = strings.TrimSuffix(password, "\r")
  }
+
+ if strings.Contains(username, ":") {
+ return types.LoginCommandOptions{}, errors.New("username cannot contain colons")
+ }
+
  return types.LoginCommandOptions{
  GOptions: globalOptions,
  Username: username,