Workaround and document weird docker issue

Signed-off-by: apostasie <[email protected]>
containerd · Oct 18, 2024 · 5f004d2 · 5f004d2
1 parent 9b1cf67
commit 5f004d2
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/cmd/nerdctl/container/container_commit_test.go b/cmd/nerdctl/container/container_commit_test.go
@@ -36,6 +36,10 @@ func TestCommit(t *testing.T) {
  helpers.Anyhow("rmi", "-f", data.Identifier())
  },
  Setup: func(data test.Data, helpers test.Helpers) {
+ // FIXME: short of pulling first, docker will fail to start the container.
+ // Debugging shows container exited immediately. Nothing in the container logs. Not much in journalctl.
+ // It is not clear what is happening.
+ helpers.Ensure("pull", testutil.CommonImage)
  helpers.Ensure("run", "-d", "--name", data.Identifier(), testutil.CommonImage, "sleep", "infinity")
  nerdtest.EnsureContainerStarted(helpers, data.Identifier())
  helpers.Ensure("exec", data.Identifier(), "sh", "-euxc", `echo hello-test-commit > /foo`)
@@ -59,6 +63,8 @@ func TestCommit(t *testing.T) {
  helpers.Anyhow("rmi", "-f", data.Identifier())
  },
  Setup: func(data test.Data, helpers test.Helpers) {
+ // See note above about docker failing.
+ helpers.Ensure("pull", testutil.CommonImage)
  helpers.Ensure("run", "-d", "--name", data.Identifier(), testutil.CommonImage, "sleep", "infinity")
  nerdtest.EnsureContainerStarted(helpers, data.Identifier())
  helpers.Ensure("exec", data.Identifier(), "sh", "-euxc", `echo hello-test-commit > /foo`)