fix: Allow to delete images when names of images are short digest ids…

… of another images

Fixed not to run `canonicalRef.String()` when canonicalRef is nil.

    ```
    canonicalRef, err := referenceutil.ParseAny(req)
    ```

Also, fixed not to run TestIssue3016 on windows.

Signed-off-by: Hayato Kiwata <[email protected]>

cmd/nerdctl/image/image_remove_test.go

@@ -319,6 +319,9 @@ func TestIssue3016(t *testing.T) {
  testCase.SubTests = []*test.Case{
  {
  Description: "Issue #3016 - Tags created using the short digest ids of container images cannot be deleted using the nerdctl rmi command.",
+ Require: test.Require(
+ test.Not(test.Windows),
+ ),
  Setup: func(data test.Data, helpers test.Helpers) {
  helpers.Ensure("pull", alpineImageName)
  helpers.Ensure("pull", busyboxImageName)

pkg/idutil/imagewalker/imagewalker.go

@@ -51,10 +51,12 @@ type ImageWalker struct {
 // Returns the number of the found entries.
 func (w *ImageWalker) Walk(ctx context.Context, req string) (int, error) {
  var filters []string
+ var canonicalRefStr string
 
  canonicalRef, err := referenceutil.ParseAny(req)
  if err == nil {
- filters = append(filters, fmt.Sprintf("name==%s", canonicalRef.String()))
+ canonicalRefStr = canonicalRef.String()
+ filters = append(filters, fmt.Sprintf("name==%s", canonicalRefStr))
  }
  filters = append(filters,
  fmt.Sprintf("name==%s", req),
@@ -75,7 +77,7 @@ func (w *ImageWalker) Walk(ctx context.Context, req string) (int, error) {
  for i, image := range images {
  uniqueImages[image.Target.Digest] = true
  // to get target image index for `nerdctl rmi <short digest ids of another images>`.
- if image.Name == canonicalRef.String() || image.Name == req {
+ if (canonicalRefStr != "" && image.Name == canonicalRefStr) || image.Name == req {
  nameMatchIndex = i
  }
  }