Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interval parsing for runc events. #104

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

austinvazquez
Copy link
Contributor

@austinvazquez austinvazquez commented Oct 29, 2023

Issue:

Closes #53

Description

Before runc events interval configurations less than 1 second would be truncated to 0. This change enables <1 second interval events channel ticks.

Signed-off-by: Austin Vazquez [email protected]

Before runc events interval configurations less than 1 second would be
truncated to 0. This change enables millisecond events channel ticks.

Signed-off-by: Austin Vazquez <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4a6db15) 21.40% compared to head (9d45239) 21.40%.

❗ Current head 9d45239 differs from pull request most recent head 47da1ff. Consider uploading reports for the commit 47da1ff to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #104   +/-   ##
=======================================
  Coverage   21.40%   21.40%           
=======================================
  Files           7        7           
  Lines         724      724           
=======================================
  Hits          155      155           
  Misses        528      528           
  Partials       41       41           
Files Coverage Δ
runc.go 21.78% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@austinvazquez austinvazquez marked this pull request as ready for review October 29, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for msec time interval in Events
2 participants