Bump github actions dependencies to match containerd CI repo and fix lint #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Archit Kulkarni <[email protected]>
|
ayup.. ci is busted.. |
|
This ci.yml should probably look more like https://github.com/containerd/plugin/blob/main/.github/workflows/ci.yml |
Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
architkulkarni
changed the title
Signed-off-by: Archit Kulkarni <[email protected]>
|
@mikebrow Okay it worked! |
|
@mikebrow is this okay to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently CI is broken with lint failures, as proved by trivial doc commits, for example https://github.com/containerd/go-cni/actions/runs/11523576454/job/32081885304
This PR updates the
setup-go,checkoutandgolangci-lint-actionversions to match those in the containerd repo. This fixes the issue.