-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement documentation syncing with containerd/containerd and on-site rendering #214
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Kazuyoshi Kato <[email protected]>
1c93a74
to
fd837a5
Compare
Looking at the preview here: https://deploy-preview-214--containerd-io.netlify.app/ This is promising progress, but I wonder how we can clean up the footer as shown in the below screen capture? Looks like these are directory names and are listed once for each file in the dir? |
I didn't even notice that, tunnel visioning on the body content. will replace with links to docs home and the readme and getting started pages for 1.7.x and 1.6.x |
shortfalls that should be addressed in followup tasks:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see progress on #163!
A few drive-by comments:
-
As mentioned in Host documentation on the website, rather than linking to GH repo #163, I strongly suggest option (1), because it is simplest. Failing that, option (2): use git submodules.
What is proposed here feels like a custom (and deferred) kind of git "submodules", that will make it challenging to have reproducible builds.
-
Can you find a way to avoid having "docs" in doc page paths? E.g.
/docs/v1.6.x/getting-started/
rather than/docs/v1.6.x/docs/getting-started/
. -
Switching to use Docsy might make your lives easier when it comes to managing doc versions.
/cc @natedoubleu @caniszczyk
netlify.toml
Outdated
@@ -3,7 +3,7 @@ publish = "public" | |||
command = "make production-build" | |||
|
|||
[build.environment] | |||
HUGO_VERSION = "0.111.3" | |||
HUGO_VERSION = "0.123.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless you really need Hugo 0.123.7, I'd suggest that you upgrade the Hugo version separately to have having too many moving parts. Hugo 0.123.x has a rewritten core, and they're still ironing out the bugs, e.g., see open-telemetry/opentelemetry.io#4064.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just needed to upgrade to 0.116.0+ to access the "like" operator on the "where" function
is there a version you would recommend?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gonna use 0.122.0 0.116.0 for now since it's the last release before the rewritten core, and because newer versions run into weird errors building jquery
@@ -20,7 +20,7 @@ | |||
<br /> | |||
|
|||
<div class="buttons is-centered"> | |||
<a class="button is-medium is-radiusless is-borderless has-text-weight-bold" href="/docs/getting-started"> | |||
<a class="button is-medium is-radiusless is-borderless has-text-weight-bold" href="/docs/v1.7.x/docs/getting-started/"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to use /docs/latest
and define a redirect rule that refers back to the latest version.
4dba8bd
to
30d9000
Compare
✅ rewrote
I could, but the reason I did it this way is because of the relative links to images and other pages in the original markdown – see the first example here. maintaining the directory structure – i.e. treating
can you clarify what specifically you mean when you say "managing doc versions"? the way I see it, this change doesn't add any responsibility of managing doc versions to the .io repo beyond simply updating to whatever the latest changes are on the specified branches of the containerd repo on a daily cadence. |
a19ec84
to
20cb44d
Compare
squashed everything up to this point because of trailing whitespace errors in the CI job |
Signed-off-by: Scott Haddlesey <[email protected]>
20cb44d
to
8c9946d
Compare
addresses #163
built on top of #121
this PR implements:
tools/refresh-docs.sh
-- script to be called by Makefile [make refresh-docs
– also made it a dependency ofmake serve
andmake *-build
].github/workflows/sync-documentation.yml
-- github workflow to callmake refresh-docs
on a cron schedule of daily at 3am, same assync-releases.yml
.currently set to operate as a pull request, and will currently generate doc sync PR on any other PR creation for the sake of demonstration, but will remove theon: pull_request: ...
before mergingthemes/containerd/layouts/partials/sidebar.html
andnested-menu-partial.html
-- adapted from hugocodex Auto-collapsing menu, enables browsing documentation