Add support for Go workspaces #999
Merged
Commits on Jul 4, 2024
-
Go 1.18 introduced support for workspaces¹, which were until now explicitly forbidden by Cachito when processing a request. The main change this feature brings is the return value for the "go list -m" command, which was used to retrieve the name of each of the modules specified as input packages in a Cachito request. This command now returns a list of all workspaces defined in the "go.work" file, which we will use to properly list them as part of the request's output. ¹ https://go.dev/ref/mod#workspaces Signed-off-by: Bruno Pimentel <[email protected]>
-
Remove the restriction in using Go workspaces
Since the support for workspaces was not properly implemented, we had a strict check on the existence of a "go.work" file in a repository, which would then trigger a failure in a request. Now that proper support is implemented, let's remove this check. Signed-off-by: Bruno Pimentel <[email protected]>
-
Add integration test to cover Go workspaces
Signed-off-by: Bruno Pimentel <[email protected]>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.