Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch secondary go install to go 1.20 #987

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

taylormadore
Copy link
Contributor

@taylormadore taylormadore commented Mar 28, 2024

The latest version of the go package available in fedora-38 has moved from go1.20 to go1.21.

Since we require both go >= 1.21 and go1.20 to be
installed in the image, switch the secondary install from go1.21 to go1.20.

Maintainers will complete the following section

  • Commit messages are descriptive enough
  • Code coverage from testing does not decrease and new code is covered
  • New code has type annotations
  • OpenAPI schema is updated (if applicable)
  • DB schema change has corresponding DB migration (if applicable)
  • README updated (if worker configuration changed, or if applicable)
  • Draft release notes are updated before merging

The latest version of the go package available in fedora-38 has moved
from go1.20 to go1.21.

Since we require both go >= 1.21 and go1.20 to be
installed in the image, switch the secondary install from go1.21 to
go1.20.

Signed-off-by: Taylor Madore <[email protected]>
@eskultety
Copy link
Member

@taylormadore taylormadore added this pull request to the merge queue Mar 28, 2024
Merged via the queue into containerbuildsystem:master with commit 9fa5c43 Mar 28, 2024
14 checks passed
@taylormadore taylormadore deleted the use-go-1.21 branch March 28, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants