Explicitly forbid workspace vendoring #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoapimentel
force-pushed
the
vet_workspace_vendoring
branch
from
1a3d8b7
to
a6314e1
Compare
brunoapimentel
force-pushed
the
vet_workspace_vendoring
branch
from
a6314e1
to
8f50224
Compare
eskultety
approved these changes
Jul 15, 2024
taylormadore
approved these changes
Jul 15, 2024
brunoapimentel
force-pushed
the
vet_workspace_vendoring
branch
from
8f50224
to
b867ab2
Compare
The ability to vendor dependencies in projects that make use of workspaces was introduced in Go 1.22. Cachito currently does not support the use of "go work vendor", so this commit introduces an explicit check for that scenario and a clearer error message. Note that by design, Go does not allow the use of "go mod vendor" if workspaces are present, so the check assumes that the existence of a vendor folder in a project with workspaces means that workspace vendoring is being used. For more info, see: - https://go.dev/doc/go1.22#tools - golang/go#60056 Signed-off-by: Bruno Pimentel <[email protected]>
brunoapimentel
force-pushed
the
vet_workspace_vendoring
branch
from
b867ab2
to
e771304
Compare
eskultety
approved these changes
Jul 16, 2024
Merged
via the queue into
containerbuildsystem:master
with commit Jul 16, 2024
63b8ec0
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ability to vendor dependencies in projects that make use of workspaces was introduced in Go 1.22. Cachito currently does not support the use of "go work vendor", so this commit introduces an explicit check for that scenario and a clearer error message.
Note that by design, Go does not allow the use of "go mod vendor" if workspaces are present, so the check assumes that the existence of a vendor folder in a project with workspaces means that workspace vendoring is being used.
Maintainers will complete the following section