Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the file dependency allowlist for gomod #1010

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Remove the file dependency allowlist for gomod #1010

merged 3 commits into from
Jun 19, 2024

Conversation

taylormadore
Copy link
Contributor

@taylormadore taylormadore commented Jun 18, 2024 •
edited by brunoapimentel
Loading

This is just for gomod. I'll follow-up with the rest after PTO.

Maintainers will complete the following section

  • Commit messages are descriptive enough
  • Code coverage from testing does not decrease and new code is covered
  • New code has type annotations
  • OpenAPI schema is updated (if applicable)
  • DB schema change has corresponding DB migration (if applicable)
  • README updated (if worker configuration changed, or if applicable)
  • Draft release notes are updated before merging

@taylormadore
remove the file dependency allowlist for gomod
d03c4fb 
File dependencies will be allowed by default for gomod, but may still be
subject to other constraints

Signed-off-by: Taylor Madore <[email protected]>
@taylormadore
fix resolve_gomod function typing
54cee5f 
The input parameters to the resolve_gomod function for the application
directory and the overall source directory are both Paths or subclasses
of Path

Signed-off-by: Taylor Madore <[email protected]>
@taylormadore
refactor gomod vetting of local file dependencies
7c8861c 
Since we no longer care if file deps are allowed, condense the path
checking into a single function that verifies that paths are not either
absolute or lead outside the repository

Signed-off-by: Taylor Madore <[email protected]>
chmeliik
chmeliik approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\o/ one down

@brunoapimentel brunoapimentel added this pull request to the merge queue Jun 19, 2024
Merged via the queue into containerbuildsystem:master with commit fea68f0 Jun 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eskultety eskultety eskultety approved these changes

@chmeliik chmeliik chmeliik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@taylormadore @eskultety @chmeliik @brunoapimentel