Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function in datasets to get input paths #367

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

anwai98
Copy link
Collaborator

@anwai98 anwai98 commented Oct 9, 2024

This PR extends support for the possibility of having paths to input images / volumes. This is in favor of computational-cell-analytics/micro-sam#728 to avoid writing additional scripts to extracts paths split-wise / data partition wise.

It's a WIP, I'll put this in review once the required (ideally all) datasets have the support for the mentioned feature.

Copy link
Owner

@constantinpape constantinpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good idea. If we standardize it we can also document it though.

torch_em/data/datasets/light_microscopy/deepbacs.py Outdated Show resolved Hide resolved
@anwai98 anwai98 requested a review from constantinpape October 9, 2024 17:47
@anwai98 anwai98 marked this pull request as ready for review October 9, 2024 17:47
Copy link
Owner

@constantinpape constantinpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good high-level. I didn't check all changes in detail. If I missed some issue we'll find it when using the datasets.

@constantinpape constantinpape merged commit d2b4b62 into constantinpape:main Oct 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants