Add ellipsis to rowProds so that method argument doesn't fail

Starts to address #7
const-ae · Sep 28, 2020 · 378374b · 378374b
1 parent 56870e0
commit 378374b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/R/methods.R b/R/methods.R
@@ -138,7 +138,7 @@ setMethod("colLogSumExps", signature(lx = "xgCMatrix"),
 #'
 #' @export
 setMethod("colProds", signature(x = "xgCMatrix"),
-          function(x, rows = NULL, cols = NULL, na.rm=FALSE){
+          function(x, rows = NULL, cols = NULL, na.rm=FALSE, ...){
   if(! is.null(rows)){
     x <- x[rows, , drop = FALSE]
   }

diff --git a/R/methods_row.R b/R/methods_row.R
@@ -116,7 +116,7 @@ setMethod("rowLogSumExps", signature(lx = "xgCMatrix"),
 #' @rdname colProds-xgCMatrix-method
 #' @export
 setMethod("rowProds", signature(x = "xgCMatrix"),
-          function(x, rows = NULL, cols = NULL, na.rm=FALSE){
+          function(x, rows = NULL, cols = NULL, na.rm=FALSE, ...){
   if(! is.null(rows)){
     x <- x[rows, , drop = FALSE]
   }

diff --git a/man/colProds-xgCMatrix-method.Rd b/man/colProds-xgCMatrix-method.Rd