Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code and 'Debug' trait bound on Input's 'interact_text*' methods #280

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

tbergerd
Copy link
Contributor

Extracted from #278 as requested.
The "term.features().is_attended()" check can never be reached because "term.is_term()" is checked at the beginning of the method (iiuc the checks are strictly equivalent).

Additionnally, the 'unwrap' call in the dead code forced a 'Debug' trait bound on the ::Err associated type.

Therefore i removed both the dead code and the now unnecessary trait bound.

@pksunkara pksunkara merged commit 7aa4afa into console-rs:master Sep 13, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants