Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not error on Key::Unknown in input and confirm #260

Merged
merged 1 commit into from
May 21, 2023
Merged

Do not error on Key::Unknown in input and confirm #260

merged 1 commit into from
May 21, 2023

Conversation

mitsuhiko
Copy link
Collaborator

On windows if you hit Ctrl or some other unmapped key the confirm prompt fails with an error otherwise.

@pksunkara
Copy link
Collaborator

I didn't merge it originally for this reason. Ref: #229

@mitsuhiko
Copy link
Collaborator Author

I think in general all of these should check for a tty and fail if not.

@mitsuhiko mitsuhiko merged commit dcb1974 into master May 21, 2023
@mitsuhiko mitsuhiko deleted the feature/no-key-unknown-catch branch May 21, 2023 20:40
@pksunkara
Copy link
Collaborator

Yup, definitely, which is what the original #148 was about.

@mitsuhiko mitsuhiko mentioned this pull request May 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pksunkara pksunkara pksunkara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitsuhiko @pksunkara