Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustyline Migration #235

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Rustyline Migration #235

wants to merge 4 commits into from

Conversation

LeoDog896
Copy link

This PR integrates rusty line into dialoguer, bringing in a number of features that aim to solve #170 and various UTF-8 issues.

@pksunkara
Copy link
Collaborator

But aren't you removing quite a few interaction related features?

@LeoDog896
Copy link
Author

Thus why I left this as a draft (though I should have specified this earlier) - I am currently reimplementing history and completion.

@LeoDog896 LeoDog896 changed the title rustyline migration Rustyline Migration Dec 23, 2022
@pksunkara
Copy link
Collaborator

FWIW, #213 is an alternate attempt to fix this. Unfortunately, all of these issues are blocked on having a proper test suite first.

@LeoDog896
Copy link
Author

Thanks for letting me know! On top of that, it also seems that rustyline doesn't have a History trait implemented yet -- until that PR is finished, the only alternative workaround is hacky, so it's better to wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants