V6 eip712 libs #20
Open
V6 eip712 libs #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pilagod
reviewed
Aug 24, 2023
src/signing/signing.ts
Outdated
Comment on lines
64
to
65
| options: SigningOptions, | ||
| signForV6?: boolean, |
There was a problem hiding this comment.
What about making type optional in the SigningOptions? If the type is provided, do the composition, otherwise just return plain signature.
In this way signForV6 could be removed, it would be better for bottom layer class to be version agnostic.
There was a problem hiding this comment.
Added a legacy boolean param to SigningOptions. If true, then signature is set for v5, else signature is for v6.
src/v6/signing.ts
Outdated
Comment on lines
31
to
36
| private keccak256 = (data: string | Uint8Array, encoding?: "utf8" | "hex"): String => { | ||
| if (typeof data === "string" && encoding === "utf8") { | ||
| return "0x" + Buffer.from(keccak_256(this.toBuffer(data, encoding))).toString("hex") | ||
| } | ||
| return "0x" + Buffer.from(keccak_256(data)).toString("hex") | ||
| } |
There was a problem hiding this comment.
I think ethers.js have keccack256 util, did you try it before?
https://docs.ethers.org/v5/api/utils/hashing/#utils-keccak256
There was a problem hiding this comment.
Refined getXXXEIP712Typehash for each type and used keccak from ethers
added 7 commits
August 25, 2023 10:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npx hardhat test --grep "Generate V6 EIP712 signature examples"at project root to generate EIP712 payloads, these data may be used in foundry test