Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: tron sign message support v2 version[R2D2-11852] #131

Merged
merged 3 commits into from
Oct 25, 2024
Merged

feat: tron sign message support v2 version[R2D2-11852] #131

merged 3 commits into from
Oct 25, 2024

Conversation

xiaoguang1010
Copy link
Contributor

Summary of Changes

tron sign message support v2 version

Motivation and Context

How Has This Been Tested? (Test Plan)

Other information

Screenshots (if appropriate):

Final checklist

  • Did you test both iOS and Android(if applicable)?
  • Is a security review needed(consenlabs/security)?

Security checklist (only for leader check)

  • No backdoor risk
    • Check for unknown network request urls, and script/shell files with unclear purposes,
    • The backend service cannot expose leaked data interfaces for various reasons (even for testing purposes)
  • No network communication protocol risk
    • Check whether to introduce unsafe network calls such as http/ws
  • No import potentially risk 3rd library
    • Check whether 3rd dependent library is import
    • Don't use an unknown third-party library
    • Check the 3rd library sources are fetched from normal sources, such as npm, gomodule, maven, cocoapod, Do not use unknown sources
    • Check github Dependabot alerts, Whether to add new issues
  • Private data not exposed
    • Check whether there are exclusive ApiKey, privatekey and other private information uploaded to git
    • Check if the packaged keystore has been uploaded to git

@xiaoguang1010 xiaoguang1010 requested a review from XuNeal October 17, 2024 01:51
XuNeal
XuNeal requested changes Oct 17, 2024
View reviewed changes
imkey-core/ikc-proto/src/tron.proto Outdated
bool is_tron_header=5;
string message = 1;
bool is_hex = 2;
bool is_tron_header = 3;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个命名太有歧义了。感觉叫做 header 分别为"none", "eth", "tron" 这种更明显一些

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已处理，修改is_tron_header字段为header，并改为string类型，通过"none", "eth", "tron" 三个参数标注message签名的头信息。

@xiaoguang1010 xiaoguang1010 requested a review from XuNeal October 17, 2024 09:30
@xiaoguang1010 xiaoguang1010 merged commit cece9e9 into dev Oct 25, 2024
5 checks passed
XuNeal added a commit that referenced this pull request Dec 23, 2024
@XuNeal @tyrone98
@xiaoguang1010 @dependabot
release dev feature (#137)
4b5eaa8 
* Feature/support dogecoin (#112)

* add dogecoin testnet & mainnet

* add dogecoin extend public key tests

* feat: add hrp to coininfo (#113)

* feat: add hrp to coininfo

* feat: add stride address test

* Feature/support dogecoin (#116)

* add dogecoin testnet & mainnet

* add dogecoin extend public key tests

* fix: fix derive dogecoin unsupported_chain error

---------

Co-authored-by: xiaoguang <[email protected]>

* feat: imkey support bitcoin psbt transaction[R2D2-11602] (#114)

* feat: add p2wpkhp2tr address generation

* feat: add bitcoin Mixed signature function

* test: modify p2wpkh test case

* feat: add bitcoin p2wpkh sign

* feat: add test case and add p2tr sign

* test: add test case

* test: modify btc test case

* feat: code optimization

* feat: modify display_addres and get_address

* feat: add bitcoin p2tr transaction

* test: add p2tr test case

* test: add bitcoin transaction sign function test

* feat: code optimization

* feat: pass in the tweaked public key when signing

* chore: code format

* feat: add imKey PSBT feature code

* feat: add p2wpkhp2tr address generation

* feat: add bitcoin Mixed signature function

* test: modify p2wpkh test case

* feat: add bitcoin p2wpkh sign

* feat: add test case and add p2tr sign

* test: add test case

* test: modify btc test case

* feat: code optimization

* feat: modify display_addres and get_address

* feat: add bitcoin p2tr transaction

* test: add p2tr test case

* test: add bitcoin transaction sign function test

* feat: code optimization

* feat: pass in the tweaked public key when signing

* chore: code format

* chore: switch to staging env

* feat: add imKey PSBT feature code

* feat: derive_account and derive_sub_account support native segwit address and bech32 address

* feat: add bitcoin psbt sign transaction

* feat: add bitcoin p2tr script sign

* fix: fix psbt legacy transaction bug

* chore: psbt code optimized

* fix: fix preview info calc error bug

* fix: modify change path to account path

* chore: code optimized

* feat: psbt transaction support sign message

* feat: add bip-322 sign message feature

* feat: add bitcoin sign message api

* chore: remove address verify function

* chore: get_utxo_pub_key function removes the network param

* chore: modify tcx version to 2.8.0

* chore: bip322 sign message  add path check and code optimization

* build: moify ios CI run-on version to macos-14

* fix: fix ios CI build error

* fix: fix cargo check error

* chore: optimization imKey public key conversion

* chore: PubKeyParam removes isSegwit field

* hotfix: import private key of dogecoin (#117)

* fix: cannot derive sub account with hrp (#118)

* feat: add top 15 chain_id and hrp verified (#121)

* ci: run unittest when push (#122)

* ci: run unittest when push

* ci: rename workflow name

* ci: fix make command error

* fix: missing test data

* chore(deps): bump openssl from 0.10.62 to 0.10.66 (#111)

Bumps [openssl](https://github.com/sfackler/rust-openssl) from 0.10.62 to 0.10.66.
- [Release notes](https://github.com/sfackler/rust-openssl/releases)
- [Commits](sfackler/rust-openssl@openssl-v0.10.62...openssl-v0.10.66)

---
updated-dependencies:
- dependency-name: openssl
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* security: remove rustc serialize (#123)

* feat: imk support mnemonic verification feature (#119)

* cosmos: derive account by chain id (#125)

* feat: force using known hrp

* feat: cosmos derive account by chainId

* fix: remove bech32_prefix from ikc (#129)

* fix: fixed the issue of Legacy and Nested Segwit transaction failure [R2D2-12387] (#128)

* fix: fixed the issue of Legacy and Nested Segwit transaction failure when btc not upgraded

* fix: wrong to address cannot be traded when appelt is not upgraded

* chore: optimization error message prompts

* feat: tron sign message support v2 version[R2D2-11852] (#131)

* feat: tron sign message support v2 version

* chore: tron sign message v2 review problem optimization

* chore: add proro field description

* feat: imKey support dogecoin[R2D2-12636] (#132)

* feat: support dogecoin address

* feat: ikc supprot dogecoin

* test: add dogecoin device_accounts test case

* test: add dogecoin device_sub_account test case

* feat: Modify the bitcoin address generation method

* feat: support dogecoin sign and add test case

* chore: modify dogecoin instance id

* test: delete useless test case

* fix: fix imkey tron ​​message signature verification failure error[R2D2-11852] (#134)

* fix: fix imkey tron ​​message signature verification failure error

* fix: fix tcx test_sign_message_by_hd testcase fail

* fix invalid signature on uncompressed wif (#135)

Co-authored-by: xiaoguang1010 <[email protected]>

* fix: imkey tron message sign error (#136)

* fix: fix imkey tron ​​message signature verification failure error

* fix: fix tcx test_sign_message_by_hd testcase fail

* raise need_password_or_derived_key when key is null (#115)

* fix: fix build error

* ci: change runner to macos 13

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: sun <[email protected]>
Co-authored-by: xiaoguang <[email protected]>
Co-authored-by: xiaoguang1010 <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuNeal XuNeal XuNeal approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaoguang1010 @XuNeal