Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove bech32_prefix from ikc #129

Merged
merged 1 commit into from
Sep 26, 2024
Merged

fix: remove bech32_prefix from ikc #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion imkey-core/ikc-proto/src/api.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,6 @@ message DeriveAccountsParam {
string segWit = 4;
string chainId = 5;
string curve = 6;
string bech32Prefix = 7;
}
repeated Derivation derivations= 1;
}
Expand Down
2 changes: 0 additions & 2 deletions imkey-core/ikc/src/api.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,6 @@ pub mod derive_accounts_param {
pub chain_id: ::prost::alloc::string::String,
#[prost(string, tag = "6")]
pub curve: ::prost::alloc::string::String,
#[prost(string, tag = "7")]
pub bech32_prefix: ::prost::alloc::string::String,
}
}
#[allow(clippy::derive_partial_eq_without_eq)]
Expand Down
1 change: 0 additions & 1 deletion imkey-core/ikc/src/handler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,6 @@ mod test {
seg_wit: "".to_string(),
chain_id: "".to_string(),
curve: "ed25519".to_string(),
bech32_prefix: "".to_string(),
}];
let param = DeriveAccountsParam { derivations };
let response = derive_accounts(&encode_message(param).unwrap());
Expand Down
30 changes: 0 additions & 30 deletions imkey-core/ikc/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,6 @@ mod tests {
seg_wit: "NONE".to_string(),
chain_id: "".to_string(),
curve: "secp256k1".to_string(),
bech32_prefix: "".to_string(),
},
Derivation {
chain_type: "LITECOIN".to_string(),
Expand All @@ -353,7 +352,6 @@ mod tests {
seg_wit: "P2WPKH".to_string(),
chain_id: "".to_string(),
curve: "secp256k1".to_string(),
bech32_prefix: "".to_string(),
},
Derivation {
chain_type: "LITECOIN".to_string(),
Expand All @@ -362,7 +360,6 @@ mod tests {
seg_wit: "NONE".to_string(),
chain_id: "".to_string(),
curve: "secp256k1".to_string(),
bech32_prefix: "".to_string(),
},
Derivation {
chain_type: "TRON".to_string(),
Expand All @@ -371,7 +368,6 @@ mod tests {
seg_wit: "".to_string(),
chain_id: "".to_string(),
curve: "secp256k1".to_string(),
bech32_prefix: "".to_string(),
},
Derivation {
chain_type: "NERVOS".to_string(),
Expand All @@ -380,7 +376,6 @@ mod tests {
seg_wit: "".to_string(),
chain_id: "".to_string(),
curve: "secp256k1".to_string(),
bech32_prefix: "".to_string(),
},
Derivation {
chain_type: "FILECOIN".to_string(),
Expand All @@ -389,7 +384,6 @@ mod tests {
seg_wit: "".to_string(),
chain_id: "".to_string(),
curve: "secp256k1".to_string(),
bech32_prefix: "".to_string(),
},
Derivation {
chain_type: "COSMOS".to_string(),
Expand All @@ -398,7 +392,6 @@ mod tests {
seg_wit: "".to_string(),
chain_id: "".to_string(),
curve: "secp256k1".to_string(),
bech32_prefix: "".to_string(),
},
Derivation {
chain_type: "EOS".to_string(),
Expand All @@ -407,7 +400,6 @@ mod tests {
seg_wit: "".to_string(),
chain_id: "".to_string(),
curve: "secp256k1".to_string(),
bech32_prefix: "".to_string(),
},
Derivation {
chain_type: "ETHEREUM".to_string(),
Expand All @@ -416,7 +408,6 @@ mod tests {
seg_wit: "".to_string(),
chain_id: "".to_string(),
curve: "secp256k1".to_string(),
bech32_prefix: "".to_string(),
},
Derivation {
chain_type: "BITCOIN".to_string(),
Expand All @@ -425,7 +416,6 @@ mod tests {
seg_wit: "NONE".to_string(),
chain_id: "".to_string(),
curve: "secp256k1".to_string(),
bech32_prefix: "".to_string(),
},
Derivation {
chain_type: "BITCOIN".to_string(),
Expand All @@ -434,7 +424,6 @@ mod tests {
seg_wit: "P2WPKH".to_string(),
chain_id: "".to_string(),
curve: "secp256k1".to_string(),
bech32_prefix: "".to_string(),
},
Derivation {
chain_type: "KUSAMA".to_string(),
Expand All @@ -443,7 +432,6 @@ mod tests {
seg_wit: "".to_string(),
chain_id: "".to_string(),
curve: "ed25519".to_string(),
bech32_prefix: "".to_string(),
},
Derivation {
chain_type: "POLKADOT".to_string(),
Expand All @@ -452,7 +440,6 @@ mod tests {
seg_wit: "".to_string(),
chain_id: "".to_string(),
curve: "ed25519".to_string(),
bech32_prefix: "".to_string(),
},
Derivation {
chain_type: "BITCOINCASH".to_string(),
Expand All @@ -461,7 +448,6 @@ mod tests {
seg_wit: "NONE".to_string(),
chain_id: "".to_string(),
curve: "secp256k1".to_string(),
bech32_prefix: "".to_string(),
},
Derivation {
chain_type: "NERVOS".to_string(),
Expand All @@ -470,7 +456,6 @@ mod tests {
seg_wit: "".to_string(),
chain_id: "".to_string(),
curve: "secp256k1".to_string(),
bech32_prefix: "".to_string(),
},
Derivation {
chain_type: "FILECOIN".to_string(),
Expand All @@ -479,7 +464,6 @@ mod tests {
seg_wit: "".to_string(),
chain_id: "".to_string(),
curve: "secp256k1".to_string(),
bech32_prefix: "".to_string(),
},
Derivation {
chain_type: "BITCOIN".to_string(),
Expand All @@ -488,7 +472,6 @@ mod tests {
seg_wit: "NONE".to_string(),
chain_id: "".to_string(),
curve: "secp256k1".to_string(),
bech32_prefix: "".to_string(),
},
Derivation {
chain_type: "BITCOIN".to_string(),
Expand All @@ -497,7 +480,6 @@ mod tests {
seg_wit: "P2WPKH".to_string(),
chain_id: "".to_string(),
curve: "secp256k1".to_string(),
bech32_prefix: "".to_string(),
},
Derivation {
chain_type: "COSMOS".to_string(),
Expand All @@ -506,7 +488,6 @@ mod tests {
seg_wit: "".to_string(),
chain_id: "".to_string(),
curve: "secp256k1".to_string(),
bech32_prefix: "".to_string(),
},
Derivation {
chain_type: "EOS".to_string(),
Expand All @@ -515,7 +496,6 @@ mod tests {
seg_wit: "".to_string(),
chain_id: "".to_string(),
curve: "secp256k1".to_string(),
bech32_prefix: "".to_string(),
},
Derivation {
chain_type: "BITCOIN".to_string(),
Expand All @@ -524,7 +504,6 @@ mod tests {
seg_wit: "VERSION_0".to_string(),
chain_id: "".to_string(),
curve: "secp256k1".to_string(),
bech32_prefix: "".to_string(),
},
Derivation {
chain_type: "BITCOIN".to_string(),
Expand All @@ -533,7 +512,6 @@ mod tests {
seg_wit: "VERSION_1".to_string(),
chain_id: "".to_string(),
curve: "secp256k1".to_string(),
bech32_prefix: "".to_string(),
},
Derivation {
chain_type: "BITCOIN".to_string(),
Expand All @@ -542,7 +520,6 @@ mod tests {
seg_wit: "VERSION_0".to_string(),
chain_id: "".to_string(),
curve: "secp256k1".to_string(),
bech32_prefix: "".to_string(),
},
Derivation {
chain_type: "BITCOIN".to_string(),
Expand All @@ -551,7 +528,6 @@ mod tests {
seg_wit: "VERSION_1".to_string(),
chain_id: "".to_string(),
curve: "secp256k1".to_string(),
bech32_prefix: "".to_string(),
},
];
let param = DeriveAccountsParam { derivations };
Expand Down Expand Up @@ -840,7 +816,6 @@ mod tests {
seg_wit: "".to_string(),
chain_id: "".to_string(),
curve: "secp256k1".to_string(),
bech32_prefix: "".to_string(),
};
let derived_accounts_result = derive_account(derivation.clone());
let mut derive_sub_accounts_param = DeriveSubAccountsParam {
Expand Down Expand Up @@ -921,7 +896,6 @@ mod tests {
seg_wit: "NONE".to_string(),
chain_id: "".to_string(),
curve: "secp256k1".to_string(),
bech32_prefix: "".to_string(),
};
let derived_accounts_result = derive_account(derivation.clone());
let mut derive_sub_accounts_param = DeriveSubAccountsParam {
Expand Down Expand Up @@ -1097,7 +1071,6 @@ mod tests {
seg_wit: "".to_string(),
chain_id: "".to_string(),
curve: "secp256k1".to_string(),
bech32_prefix: "".to_string(),
};
let derived_accounts_result = derive_account(derivation);
let derive_sub_accounts_param = DeriveSubAccountsParam {
Expand Down Expand Up @@ -1146,7 +1119,6 @@ mod tests {
seg_wit: "".to_string(),
chain_id: "".to_string(),
curve: "secp256k1".to_string(),
bech32_prefix: "".to_string(),
};
let derived_accounts_result = derive_account(derivation.clone());
let mut derive_sub_accounts_param = DeriveSubAccountsParam {
Expand Down Expand Up @@ -1228,7 +1200,6 @@ mod tests {
seg_wit: "".to_string(),
chain_id: "".to_string(),
curve: "secp256k1".to_string(),
bech32_prefix: "".to_string(),
};
let derived_accounts_result = derive_account(derivation.clone());
let mut derive_sub_accounts_param = DeriveSubAccountsParam {
Expand Down Expand Up @@ -1309,7 +1280,6 @@ mod tests {
seg_wit: "NONE".to_string(),
chain_id: "".to_string(),
curve: "secp256k1".to_string(),
bech32_prefix: "".to_string(),
};
let derived_accounts_result = derive_account(derivation.clone());
let mut derive_sub_accounts_param = DeriveSubAccountsParam {
Expand Down
Loading