-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: imk support mnemonic verification feature[R2D2-11881] #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuNeal
approved these changes
Aug 23, 2024
XuNeal
approved these changes
Aug 27, 2024
@@ -40,6 +40,8 @@ pub enum ApduError { | |||
ImkeyInMenuPage, | |||
#[error("imkey_pin_not_verified")] | |||
ImkeyPinNotVerified, | |||
#[error("imkey_mnemonic_check_fail")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: 其实这里最好是 Check Failed
XuNeal
added a commit
that referenced
this pull request
Dec 23, 2024
* Feature/support dogecoin (#112) * add dogecoin testnet & mainnet * add dogecoin extend public key tests * feat: add hrp to coininfo (#113) * feat: add hrp to coininfo * feat: add stride address test * Feature/support dogecoin (#116) * add dogecoin testnet & mainnet * add dogecoin extend public key tests * fix: fix derive dogecoin unsupported_chain error --------- Co-authored-by: xiaoguang <[email protected]> * feat: imkey support bitcoin psbt transaction[R2D2-11602] (#114) * feat: add p2wpkhp2tr address generation * feat: add bitcoin Mixed signature function * test: modify p2wpkh test case * feat: add bitcoin p2wpkh sign * feat: add test case and add p2tr sign * test: add test case * test: modify btc test case * feat: code optimization * feat: modify display_addres and get_address * feat: add bitcoin p2tr transaction * test: add p2tr test case * test: add bitcoin transaction sign function test * feat: code optimization * feat: pass in the tweaked public key when signing * chore: code format * feat: add imKey PSBT feature code * feat: add p2wpkhp2tr address generation * feat: add bitcoin Mixed signature function * test: modify p2wpkh test case * feat: add bitcoin p2wpkh sign * feat: add test case and add p2tr sign * test: add test case * test: modify btc test case * feat: code optimization * feat: modify display_addres and get_address * feat: add bitcoin p2tr transaction * test: add p2tr test case * test: add bitcoin transaction sign function test * feat: code optimization * feat: pass in the tweaked public key when signing * chore: code format * chore: switch to staging env * feat: add imKey PSBT feature code * feat: derive_account and derive_sub_account support native segwit address and bech32 address * feat: add bitcoin psbt sign transaction * feat: add bitcoin p2tr script sign * fix: fix psbt legacy transaction bug * chore: psbt code optimized * fix: fix preview info calc error bug * fix: modify change path to account path * chore: code optimized * feat: psbt transaction support sign message * feat: add bip-322 sign message feature * feat: add bitcoin sign message api * chore: remove address verify function * chore: get_utxo_pub_key function removes the network param * chore: modify tcx version to 2.8.0 * chore: bip322 sign message add path check and code optimization * build: moify ios CI run-on version to macos-14 * fix: fix ios CI build error * fix: fix cargo check error * chore: optimization imKey public key conversion * chore: PubKeyParam removes isSegwit field * hotfix: import private key of dogecoin (#117) * fix: cannot derive sub account with hrp (#118) * feat: add top 15 chain_id and hrp verified (#121) * ci: run unittest when push (#122) * ci: run unittest when push * ci: rename workflow name * ci: fix make command error * fix: missing test data * chore(deps): bump openssl from 0.10.62 to 0.10.66 (#111) Bumps [openssl](https://github.com/sfackler/rust-openssl) from 0.10.62 to 0.10.66. - [Release notes](https://github.com/sfackler/rust-openssl/releases) - [Commits](sfackler/rust-openssl@openssl-v0.10.62...openssl-v0.10.66) --- updated-dependencies: - dependency-name: openssl dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * security: remove rustc serialize (#123) * feat: imk support mnemonic verification feature (#119) * cosmos: derive account by chain id (#125) * feat: force using known hrp * feat: cosmos derive account by chainId * fix: remove bech32_prefix from ikc (#129) * fix: fixed the issue of Legacy and Nested Segwit transaction failure [R2D2-12387] (#128) * fix: fixed the issue of Legacy and Nested Segwit transaction failure when btc not upgraded * fix: wrong to address cannot be traded when appelt is not upgraded * chore: optimization error message prompts * feat: tron sign message support v2 version[R2D2-11852] (#131) * feat: tron sign message support v2 version * chore: tron sign message v2 review problem optimization * chore: add proro field description * feat: imKey support dogecoin[R2D2-12636] (#132) * feat: support dogecoin address * feat: ikc supprot dogecoin * test: add dogecoin device_accounts test case * test: add dogecoin device_sub_account test case * feat: Modify the bitcoin address generation method * feat: support dogecoin sign and add test case * chore: modify dogecoin instance id * test: delete useless test case * fix: fix imkey tron message signature verification failure error[R2D2-11852] (#134) * fix: fix imkey tron message signature verification failure error * fix: fix tcx test_sign_message_by_hd testcase fail * fix invalid signature on uncompressed wif (#135) Co-authored-by: xiaoguang1010 <[email protected]> * fix: imkey tron message sign error (#136) * fix: fix imkey tron message signature verification failure error * fix: fix tcx test_sign_message_by_hd testcase fail * raise need_password_or_derived_key when key is null (#115) * fix: fix build error * ci: change runner to macos 13 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: sun <[email protected]> Co-authored-by: xiaoguang <[email protected]> Co-authored-by: xiaoguang1010 <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
imk support mnemonic verification feature
https://imtoken.atlassian.net/browse/R2D2-11881
Motivation and Context
How Has This Been Tested? (Test Plan)
Other information
Screenshots (if appropriate):
Final checklist
Security checklist (only for leader check)