Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: imKey bitcon support taproot and native segwit transaction[R2D2-11241] #102

Merged
merged 38 commits into from
Dec 23, 2024

Conversation

xiaoguang1010
Copy link
Contributor

Summary of Changes

imKey bitcon support taproot transaction

https://imtoken.atlassian.net/jira/software/c/projects/R2D2/boards/31?assignee=6100f4534e8d8d006927ea11&selectedIssue=R2D2-11241

Motivation and Context

How Has This Been Tested? (Test Plan)

Other information

Screenshots (if appropriate):

Final checklist

  • Did you test both iOS and Android(if applicable)?
  • Is a security review needed(consenlabs/security)?

Security checklist (only for leader check)

  • No backdoor risk
    • Check for unknown network request urls, and script/shell files with unclear purposes,
    • The backend service cannot expose leaked data interfaces for various reasons (even for testing purposes)
  • No network communication protocol risk
    • Check whether to introduce unsafe network calls such as http/ws
  • No import potentially risk 3rd library
    • Check whether 3rd dependent library is import
    • Don't use an unknown third-party library
    • Check the 3rd library sources are fetched from normal sources, such as npm, gomodule, maven, cocoapod, Do not use unknown sources
    • Check github Dependabot alerts, Whether to add new issues
  • Private data not exposed
    • Check whether there are exclusive ApiKey, privatekey and other private information uploaded to git
    • Check if the packaged keystore has been uploaded to git

@xiaoguang1010 xiaoguang1010 requested a review from tyrone98 June 25, 2024 07:45
xiaoguang1010 and others added 15 commits July 2, 2024 12:04
* Add PsbtSigner

* finish taproot sign in psbt

* feat: add taproot sign script

fix: rebase issue

fix: append script and control block to witness

* fix: sign tap script no need tweak privatekey

Fix after rebase

* fix: merge missing code

* chore: remove println hash

* add bip322 message signature

* add multi address type in bitcoin psbt

* add tests for bitcoin bip322 sign

---------

Co-authored-by: Sun Feng <[email protected]>
* fix: remove deprecated fil library

* feat: upgrade deprecated fil dep in ikc

* Update build-release-ios.yml runs-on

* Update build-release-ios.yml runs-on macos-14

* feat: remove forest_bigint support
@xiaoguang1010 xiaoguang1010 merged commit 818de5f into main Dec 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants