feat: implement dynamic behavior for halfOpenAfter #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't added anything to the readme because I didn't really see a proper place for documenting the new behavior of |
ghost91-
force-pushed
the
dynamic-half-open-after
branch
3 times, most recently
from
701daae to
23981f6
Compare
ghost91-
force-pushed
the
dynamic-half-open-after
branch
from
23981f6 to
3f79ed6
Compare
connor4312
reviewed
Jul 22, 2024
| @@ -167,7 +198,7 @@ export class CircuitBreakerPolicy implements IPolicy { | |||
| return this.execute(fn); | |||
|
|
|||
| case CircuitState.Open: | |||
| if (Date.now() - state.openedAt < this.options.halfOpenAfter) { | |||
| if (Date.now() - state.openedAt < (this.halfOpenAfterBackof?.duration ?? 0)) { | |||
There was a problem hiding this comment.
The halfOpenAfterBackoff should be stored in the state to avoid the null assertion (which should never happen)
There was a problem hiding this comment.
Good point! I didn't think of that.
|
Merged in 99e5887 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #68