feat: provide attempt number to onRetry callback #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connor4312
reviewed
Jul 19, 2024
| }); | ||
|
|
||
| await expect(policy.execute(s)).to.eventually.be.rejectedWith(MyErrorA); | ||
| expect(attempts).to.deep.equal([1, 2, 3]); |
There was a problem hiding this comment.
The documentation says attempts should start at 0, but it starts at 1 here. I don't feel strongly either way but one of the two should be updated.
There was a problem hiding this comment.
Or maybe the documentation is just a little bit unclear. I would say "starting at 1" since 0 doesn't actually get emitted in the retry.
There was a problem hiding this comment.
I'll adapt the docs
ghost91-
force-pushed
the
provide-attempt-to-on-retry
branch
from
4ab8408 to
c87512e
Compare
connor4312
approved these changes
Jul 19, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #90