(rebase #782) Proper handling of length defined data fields #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbirchmeier
force-pushed
the
pr782-blackedgecapital-data_field_length_parsing
branch
2 times, most recently
from
4e744d5
to
c7ce3d8
Compare
dominicpalmer
approved these changes
Feb 13, 2024
|
Thanks @gbirchmeier, looks good to me. |
larsope
approved these changes
Feb 13, 2024
- use XmlDataLen field to parse XmdData in FIX messags rather than looking for delimiters - added test pr connamara#782
gbirchmeier
force-pushed
the
pr782-blackedgecapital-data_field_length_parsing
branch
from
c7ce3d8
to
00844b5
Compare
gbirchmeier
deleted the
pr782-blackedgecapital-data_field_length_parsing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See pr #782 for original discussion
attn @larsope @dominicpalmer @michal-ciechan @jpetrucciani -- (people wrote/commented/liked the previous PR) -- I rebased that fix into the current version, please have a quick look and let me know if you have any comments.
Note: I moved the UT from DataDictionaryTests.cs to MessageTests.cs (the behavior being tested is a Message function, not a DD function), and added a new UT to clarify what happens if 212/XmlDataLen isn't present.